[lldpmgrd] Inherit DaemonBase class from sonic-py-common package #5370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -198,6 +158,13 @@ class LldpManager(object): | |||
| Subscribe to CONFIG_DB - get notified of port config changes | |||
| Update LLDP configuration accordingly. | |||
| """ | |||
| self.log_info("Starting up...") | |||
|
|
|||
| if not os.geteuid() == 0: | |||
There was a problem hiding this comment.
Should it be part of the base class?
We can initialize the base class with parameters?
There was a problem hiding this comment.
This is a good suggestion for a future improvement. For now I'd like to transition daemons to inherit from the base class as-is, then we can assess other remaining duplicated code (like this), and make improvements accordingly.
11 tasks
|
Retest vsimage please |
pavel-shirshov
approved these changes
Sep 15, 2020
abdosi
pushed a commit
that referenced
this pull request
Sep 19, 2020
Eliminate duplicate logging and signal handling code by inheriting from DaemonBase class in sonic-py-common package.
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…ic-net#5370) Eliminate duplicate logging and signal handling code by inheriting from DaemonBase class in sonic-py-common package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Eliminate duplicate logging and signal handling code by inheriting from DaemonBase class in sonic-py-common package.
- How to verify it
Ensure lldpmgrd functionality is unchanged
- Which release branch to backport (provide reason below if selected)