Minigraph resource type changes #5198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
Aug 17, 2020
prsunny
previously approved these changes
Aug 17, 2020
|
retest this please |
abdosi
previously approved these changes
Aug 31, 2020
|
retest this please |
pavel-shirshov
approved these changes
Oct 6, 2020
pavel-shirshov
added
Enhancement ➕
Request for 201911 Branch 
Request for 202006 Branch
sonic-cfggen
abdosi
approved these changes
Oct 6, 2020
prsunny
approved these changes
Oct 7, 2020
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
* Parse sub_role from minigraph into DEVICE_METADATA * Change minigraph sub_role to resource_type
|
@anish-n will not take it for 201911. I assume it's ok ? |
Yes we don't need it in 201911 |
abdosi
pushed a commit
that referenced
this pull request
Jul 29, 2022
* Parse sub_role from minigraph into DEVICE_METADATA * Change minigraph sub_role to resource_type
abdosi
pushed a commit
that referenced
this pull request
Aug 1, 2022
* Parse sub_role from minigraph into DEVICE_METADATA * Change minigraph sub_role to resource_type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Enhancement ➕
Request for 201911 Branch
Request for 202006 Branch
sonic-cfggen
SONiC Configuration Generator Tool
Request for 202006 Branch
sonic-cfggen
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Add resource_type from minigraph to DEVICE_METADATA section
- How I did it
Add parsing for field in minigraph metadata section
- How to verify it
Unit testing in sonic-config-engine
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
Add minigraph resource_type to DEVICE_METADATA section
- A picture of a cute animal (not mandatory but encouraged)