Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[device/Celestica] Introduce Silverstone2 platform module #4451

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

pphuchar
Copy link
Contributor

@pphuchar pphuchar commented Apr 21, 2020

- What I did
Introduce the Celestica Silverstone2 device platform to the Broadcom image.
Only the platform driver module and device plugins.

- How I did it
Add the kernel module driver and basic device plugins and HwSKU skeleton.

- How to verify it
The platform module starts after SONiC bootup.
Verify basic plugins: sfputil, psuutil, and eeprom
Read sensor from BMC.

- Description for the changelog

  • Introduce Celestica Silverstone2 platform device

Test log:
silverstone2_porting_test.md.log
Buster test log:
silverstone2_porting_test_buster.md.log

@pphuchar pphuchar marked this pull request as ready for review April 21, 2020 09:53
@lgtm-com
Copy link

lgtm-com bot commented Apr 21, 2020

This pull request introduces 1 alert when merging 572667b into d1940b2 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Apr 21, 2020

This pull request introduces 1 alert when merging 055cc2c into bddd0d1 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2020

This pull request introduces 1 alert when merging 90f03e7 into c52b8c4 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lguohan
Copy link
Collaborator

lguohan commented Apr 30, 2020

retest broadcom please

@lguohan
Copy link
Collaborator

lguohan commented Apr 30, 2020

retest vsimage please

* Andreas Larsson <andreas@gaisler.com>
*/

#include <linux/clk.h>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the linux kernel one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update this PR to use kernel's i2c-ocores after this sonic-net/sonic-linux-kernel#135 merged.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr has been merged.

Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request introduces 1 alert when merging e3c1b80 into 6d0f8dc - view on LGTM.com

new alerts:

  • 1 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants