[Yang][Bugfix] Vxlan tunnel yang model to support dest_ip and name length. #18966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Tunnel name of length 30 characters. 2) dst_ip field.
qiluo-msft
reviewed
May 16, 2024
| @@ -55,13 +55,17 @@ module sonic-vxlan { | |||
| name should have a max of 10 chars */ | |||
|
|
|||
| type string { | |||
| length 1..10; | |||
| length 1..30; | |||
There was a problem hiding this comment.
I chose a random sufficiently large number to accommodate the name.
There was a problem hiding this comment.
linux interface same is 15 character so we cant use that.
There was a problem hiding this comment.
Could you keep the lower limit 1?
wen587
approved these changes
May 17, 2024
|
@qiluo-msft if you are ok with with the length then please merge this. |
ganglyu
approved these changes
May 23, 2024
qiluo-msft
approved these changes
May 23, 2024
|
Hi @yxieca , could you help merge to 202311? |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 20, 2024
…ngth. (sonic-net#18966) Fixed the Vxlan tunnel yang model to add support for 1) Tunnel name length restriction has been removed 2) dst_ip field. #### Why I did it The yand modle was misisng an element and supported tunnel anme was very small. #### How to verify it run yang model tests
|
Cherry-pick PR to 202311: #19364 |
mssonicbld
pushed a commit
that referenced
this pull request
Jun 21, 2024
…ngth. (#18966) Fixed the Vxlan tunnel yang model to add support for 1) Tunnel name length restriction has been removed 2) dst_ip field. #### Why I did it The yand modle was misisng an element and supported tunnel anme was very small. #### How to verify it run yang model tests
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the Vxlan tunnel yang model to add support for
Why I did it
The yand modle was misisng an element and supported tunnel anme was very small.
Work item tracking
27996821
How I did it
How to verify it
run yang model tests
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)