Linecard startup-TSA-TSB #18496
Linecard startup-TSA-TSB #18496
Conversation
|
@sanjair-git for viz |
|
@rlhui @arlakshm @judyjoseph @abdosi @deepak-singhal0408 Created this PR for master |
| @@ -0,0 +1,15 @@ | |||
| [Unit] | |||
| Description= STARTUP TSA-TSB SERVICE | |||
| Requires=updategraph.service database.service | |||
There was a problem hiding this comment.
updategraph service is a 202205 only service which in 202405 is replaced by config-setup service. May need to change this accordingly.
…art a timer to configure TSB and configure TSB when the timer expires Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
…minigraph.service Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
saksarav-nokia
force-pushed
the
saksarav-nokia-tsa-tsb
branch
from
8f35ba6
to
ab5e601
Compare
|
@gechiang , I have update the master PR with the fix |
|
@abdosi , could you please restart the azure pipeline? |
saksarav-nokia
changed the title
|
/azpw run Azure.sonic-buildimage |
|
@judyjoseph , @lguohan @abdosi , could you please review and merge it? |
| return True; | ||
| else: | ||
| tsa_enabled = get_tsa_config("") | ||
| if tsa_enabled == 'false': |
There was a problem hiding this comment.
why is tsa_enabled not returned as it is? The function return value is confusing
There was a problem hiding this comment.
Tejaswini, The startup-tsa-tsb service is global and the checks in get_tsa_status makes sure that the service is started only when the tsa_enabled flag is set to false for all namespaces in multi-asic and in the global config for pizza box.
Why I did it
The traffic loss is seen when the chassis or Linecard is rebooted . Cloning the sonic-net/sonic-buildimage-msft#206 to master
Work item tracking
How I did it
Start a service startup_tsa_tsb.service when the IMM comes up
This service configures TSA and starts a timer which is provided in device/startup-tsa-tsb.conf for every platform. This service will exit with NOP if the platform doesn't have startup-tsa-tsb.conf in the device folder.
If the CONFIG_DB has TSA configured already, the service will exit.
When the timer expires, TSB is configured
Enhanced "sudo TSC" command output to indicate TSB pending with the remaining timer value and service name if the service is running
If the operator issues "sudo TSA" explicitly while the startup_tsa_tsb.service is running, service will be stopped.
How to verify it
Verified that the service is started only in IMM
Verified that the service runs only if device/startup-tsa-tsb.conf file exists
Verified that the TSA is configured and routes are not advertised to eBGP neighbors till TSB timer expires and TSB is configured.
"sudo TSC" shows the TSB Pending with remaining timer interval
Service is stopped when the operator issues "sudo TSA"
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)