[build] Migrate libyang2 sources download from wget to dget (#13504) #13517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t#13394) According to its manual page, "[dget in its] first form, [..] fetches the requested URLs. If this is a .dsc or .changes file, then dget acts as a source-package aware form of wget: it also fetches any files referenced in the .dsc/.changes file. The downloaded source is then checked with dscverify and, if successful, unpacked by dpkg-source." Thus, when possible, dget use is preferable to wget so that sources authenticity can be performed automatically by dscverify" Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
guillaumelambert
changed the title
qiluo-msft
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to its manual page,
"[dget in its] first form, [..] fetches the requested URLs. If this is a .dsc or .changes file, then dget acts as a source-package
aware form of wget: it also fetches any files referenced in the
.dsc/.changes file.
The downloaded source is then checked with dscverify and, if successful, unpacked by dpkg-source."
Thus, when possible, dget use is preferable to wget so that sources authenticity can be performed automatically by dscverify"
Previous commit in PR #13394 has been removed
because it switched the debian repository from its mirror in SONiC at https://sonicstorage.blob.core.windows.net
to debian official repository at https://deb.debian.org/debian/pool/main/liby/libyang2/
This version of the package was in debian testing and after having taken a look at the repo content
at https://deb.debian.org/debian/pool/main/liby/libyang2/ it appears it was removed from the official distribution.
and superseded by a more recent version 2.1.30.
This new commit restores the URL at the mirror
dget https://sonicstorage.blob.core.windows.net/debian/pool/main/liby/libyang/libyang2_2.0.112-6.dsc
to address the following issue #13504
Note that debian-keyring must be installed on your system to run this command that performs a signature verification,
what is not the case by default in Ubuntu.
$ sudo apt-get install debian-keyring
Which release branch to backport (provide reason below if selected)
all branches using libyang2 sources
Description for the changelog
[build] Migrate libyang2 sources download from wget to dget
A picture of a cute animal (not mandatory but encouraged)