[BFN] Cherry-pick qsfp eeprom reading fix to 202111 #12129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytroxIntel
changed the title
dmytroxIntel
force-pushed
the
port_qsfp_eeprom_fix
branch
from
e25b459
to
b52af2e
Compare
prgeor
approved these changes
Oct 12, 2022
|
@prgeor , please merge, it's intel specific changes |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
dmytroxIntel
force-pushed
the
port_qsfp_eeprom_fix
branch
from
aa9d4c8
to
5ba4fba
Compare
|
/azp run |
|
Commenter does not have sufficient privileges for PR 12129 in repo sonic-net/sonic-buildimage |
dmytroxIntel
force-pushed
the
port_qsfp_eeprom_fix
branch
from
5ba4fba
to
179f5c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Moving to new sonic xcvr api requires exposing eeprom pages, by that time platform api was providing only PAGE0_LOWER and PAGE0_UPPER. That led threshold specific tests to fail since sff3686 declares threshold information on the third page.
This is also a root cause for other bugs.
How I did it
Used new api exposed from platform side in order to make it possible to read all pages.
How to verify it
Run sonic mgmt sfp tests.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)