Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform/Seastone2] add optoe based sfp implementation #11756

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

qnos
Copy link
Contributor

@qnos qnos commented Aug 17, 2022

Why I did it

Add sfp-refactor optoe based sfp implementation for Seastone2

How I did it

Inherit and implement the sfp api according to new sfp-refactor
architecture

How to verify it

Verify sfp status and sfp configure commands on seastone2 with new
implementation

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@qnos qnos requested a review from lguohan as a code owner August 17, 2022 07:23
@lgtm-com
Copy link

lgtm-com bot commented Aug 17, 2022

This pull request introduces 3 alerts when merging c6f43fccae63cd2ebe064c2a092677195db0ac02 into 5846cdd - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Wrong number of arguments in a class instantiation

@lgtm-com
Copy link

lgtm-com bot commented Aug 18, 2022

This pull request introduces 1 alert when merging e04a7d3212cc4f089b2b1ddb3fb69fc32168a22e into 5d9a463 - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a class instantiation

@qnos qnos force-pushed the cel-sea2-sfp-optoe-support branch from e04a7d3 to b6389e5 Compare August 23, 2022 01:04
@lgtm-com
Copy link

lgtm-com bot commented Aug 23, 2022

This pull request introduces 1 alert when merging b6389e533586f205fcd6d08605c18f1c1c2a85f1 into 2501d1f - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a class instantiation

@qnos qnos force-pushed the cel-sea2-sfp-optoe-support branch from b6389e5 to dcee1ce Compare August 26, 2022 09:39
@lgtm-com
Copy link

lgtm-com bot commented Aug 26, 2022

This pull request introduces 1 alert when merging dcee1ce5f1dcdc9b5ec942bcc72fe061a0ea2eb1 into a1eae94 - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a class instantiation

@qnos qnos force-pushed the cel-sea2-sfp-optoe-support branch from a9c5cdd to 20c9e60 Compare August 29, 2022 01:35
@lgtm-com
Copy link

lgtm-com bot commented Aug 29, 2022

This pull request introduces 1 alert when merging 20c9e6008ea1e0aa572450c4d610967d4ba2154f into 178a30b - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a class instantiation

@qnos qnos force-pushed the cel-sea2-sfp-optoe-support branch from 20c9e60 to 0c4870d Compare October 14, 2022 00:51
Why I did it
Add sfp-refactor optoe based sfp implementation for Seastone2

How I did it
Inherit and implement the sfp api according to new sfp-refactor
architecture

How to verify it
Verify sfp status and sfp configure commands on seastone2 with new
implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant