[Edgecore][as4630_54te/as5835_54x] Fix wrong "show platform fan" status #11546
+100
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
as4630_54te: 1. Fix wrong fan direction 2. Fix wrong get_status_led() 3. Fix wrong get_status() when psu power good failed as5835_54x: 1. Fix wrong get_status_led() 2. Fix wrong get_status() when psu power good failed 3. Fix wrong sysfs path of rear fan Signed-off-by: Brandon Chuang <brandon_chuang@edge-core.com>
brandonchuang
force-pushed
the
as4630_as5835_fan
branch
from
da78dee
to
5e00ec3
Compare
8 tasks
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
show platform fan status is not correct.
How I did it
Modify fan.py/fan_drawer.py
How to verify it
show platform fan
Which release branch to backport (provide reason below if selected)