Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete defunct temporary username/password that leaked into the readme #40

Merged
merged 1 commit into from
May 13, 2024
Merged

Delete defunct temporary username/password that leaked into the readme #40

merged 1 commit into from
May 13, 2024

Conversation

ryanhamel
Copy link
Contributor

No description provided.

@ryanhamel ryanhamel requested review from aditigaur4 and bwatrous and removed request for aditigaur4 May 13, 2024 18:20
bwatrous
bwatrous approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@bwatrous bwatrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionally, we could also replace the username and pw with ******* or something so that people following the example notice that they need to change this?

@ryanhamel ryanhamel removed the request for review from aditigaur4 May 13, 2024 18:39
@ryanhamel ryanhamel closed this May 13, 2024
@ryanhamel ryanhamel reopened this May 13, 2024
@ryanhamel ryanhamel merged commit 51b788a into master May 13, 2024
1 check passed
@ryanhamel ryanhamel deleted the ryhamel/erase-defunct-creds branch May 13, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwatrous bwatrous bwatrous approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanhamel @bwatrous