Routed Subinterface enhancements #833
Conversation
MTU & admin status enhancements for Routed Subinterfaces
| * Per sub port interface admin status config | ||
| - Kernel subinterface netdev admin UP can be performed only if parent interface netdev is admin UP. |
There was a problem hiding this comment.
Do we have any db-migrator section to describe for long subinterface name to short interface name conversion in config-db across releases?
There was a problem hiding this comment.
Yes, we have to handle subinterface name conversion in db_migrator script during upgrade & downgrade.
Updated in next commit.
There was a problem hiding this comment.
Updated to support both short name and long name format for creating subinterfaces. With this no need to handle DB conversion while performing upgrade.
| MTU inherited from parent physical port or port channel. | ||
| If subinterface MTU is configured, MTU on subinterface will be configured with: | ||
| - If Subinterface MTU <= parent port MTU, configured subinterface MTU will be applied. | ||
| - If Subinterface MTU > parent port MTU, parent port MTU will be applied. |
There was a problem hiding this comment.
Dont we throw an error in this case?
There was a problem hiding this comment.
As discussed in review meeting, user can change MTU on parent interface. Restricting this update depending on MTU of subinterfaces will be hard for user since there could be 100s of subinterfaces under the parent interface.
| ### 2.1.1 config_db.json | ||
| ### 2.1.1 Naming Convention for sub-interfaces: | ||
|
|
||
| Since Kernel has netdevice name length restriction to 15, port channel sub-interfaces(Physical interfaces as well in case interface number > 99) cannot follow the same nomenclature as physical sub-interfaces. Hence Long name to short name conversion needs to be performed for the subinterfaces. |
There was a problem hiding this comment.
If parent physical interface has interface number which exceeds 2 digits, subinterface name length will exceed 15 characters with existing subinterface naming convention. This results in failure of subinterface netdev creation in kernel.
To be more specific, this subinterface netdev name length issue is not specific to PortChannel subinterfaces, but also applicable to physical subinterfaces.
|
|
||
| mtu of a sub port interface is inherited from its parent physical port or port channel, and is not configurable in the current design. | ||
| In Click CLI, user will be able to configure the vlan id associated with the sub-interface. If vlan_id is not provided, sub-interface ID will be used as vlan id. |
There was a problem hiding this comment.
I think, we should mandate vlan_id configuration even from Click CLI and we should not assume sub-interface id as vlan-id.
There was a problem hiding this comment.
Updated in next commit where vlan id is mandatory for short name format subinterfaces. But for existing long name format subinterfaces, there is no vlan id hence its not applicable.
|
@wendani for review |
Coexistence with existing long name format subinterfaces
|
Please capture all associated PRs in description for ease of tracking. |
Updated Description with code PRs. |
Done. |
under swss library instead of swss-common library.
|
As discussed in the community meeting today(11/16), please also plan to add sonic-mgmt tests for this feature. This is required for all features that is to be added to release notes. |
|
@prsunny and @preetham-singh which sonic-mgmt test covers this enhancement? |
Naming convention update for routed subinterfaces.
PortChannel Routed subinterface support.
MTU & admin status enhancements for Routed Subinterfaces.