Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AKS cluster autoscaler #218

Closed
BernieWhite opened this issue Dec 30, 2019 · 5 comments · Fixed by #876
Closed

Enable AKS cluster autoscaler #218

BernieWhite opened this issue Dec 30, 2019 · 5 comments · Fixed by #876
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed rule: azure-kubernetes-service Rules for Azure Kubernetes Service
Milestone

Comments

@BernieWhite
Copy link
Collaborator

Rule request

Suggested rule change

AKS clusters deployed with scale sets should enable the cluster autoscaler.

Applies to the following

The rule applies to the following:

  • Resource type: Microsoft.ContainerService/managedClusters

Additional context

Azure template reference

@BernieWhite BernieWhite added the rule The issue relates to a rule label Dec 30, 2019
@BernieWhite BernieWhite added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 6, 2020
@BernieWhite BernieWhite added rule: azure-kubernetes-service Rules for Azure Kubernetes Service and removed rule The issue relates to a rule labels Jul 22, 2020
@ArmaanMcleod
Copy link
Contributor

@BernieWhite I can help make a PR for this rule.

@BernieWhite
Copy link
Collaborator Author

@ArmaanMcleod Great thanks. Let me assign that to you. If you have any issues let me know.

@ArmaanMcleod
Copy link
Contributor

ArmaanMcleod commented Aug 12, 2021

@BernieWhite No worries. When creating the rule for the first time which ruleset tag to do you put it under? I'm assuming I can use 2021_06 since that's the latest.

I also see the following baselines:

baselines

Do I also need to referece the rule .md files in here as well? I can include it in Azure.GA_2021_06.md and Azure.All.md. Should it also go into Azure.Default.md?

@BernieWhite
Copy link
Collaborator Author

BernieWhite commented Aug 12, 2021

@ArmaanMcleod The ruleset references the quarterly baseline rules are released in. For new rules this is the next quarterly baseline so the next baseline would be 2021_09. Release GA and preview is determines by the Azure feature, so in this case AKS cluster autoscaler is a GA Azure features so it would be GA.

The quarterly baseline is designed to be a stable checkpoint for customers. So, if they are not ready to adopt new rules immediately, they can target a quarterly baseline and get a stable position even though we add rules each month.

At the end of the quarter, we cut a new baseline and deprecate the old one, which reports as a warning.

You don't need to worry about updating an old quarterly baseline. For Azure.All.md and Azure.Default.md, you can run the Rule docs task in VSCode and that should regenerate these files, ideally do this before you submit the PR.

@ArmaanMcleod
Copy link
Contributor

@BernieWhite Thanks, added a Azure.AKS.Autoscaling rule in the PR. Should be ready for review.

@BernieWhite BernieWhite added this to the v1.7.0 milestone Aug 15, 2021
@BernieWhite BernieWhite mentioned this issue Aug 25, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed rule: azure-kubernetes-service Rules for Azure Kubernetes Service
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants