Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The way of checking that a VM or VMSS has Linux doesn't cover all cases #1704

Closed
VeraBE opened this issue Sep 23, 2022 · 0 comments · Fixed by #1701
Closed

The way of checking that a VM or VMSS has Linux doesn't cover all cases #1704

VeraBE opened this issue Sep 23, 2022 · 0 comments · Fixed by #1701
Labels
bug Something isn't working
Milestone
v1.20.0

Comments

@VeraBE
Copy link
Contributor

VeraBE commented Sep 23, 2022

The way PSRule currently checks if a VM or VMSS has Linux installed doesn't cover all cases: storageProfile.osDisk.osType and virtualMachineProfile.osProfile.linuxConfiguration could be undefined in an ARM template

This check is used for the preconditions of Azure.VM.PublicKey and Azure.VMSS.PublicKey
@VeraBE VeraBE added the bug Something isn't working label Sep 23, 2022
@VeraBE VeraBE mentioned this issue Sep 23, 2022
Merged
11 tasks
@BernieWhite BernieWhite added this to the v1.20.0 milestone Sep 23, 2022
@BernieWhite BernieWhite mentioned this issue Sep 25, 2022
Merged
4 tasks
@BernieWhite BernieWhite mentioned this issue Oct 8, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.20.0
Development

Successfully merging a pull request may close this issue.

Improve Azure.VM.PublicKey and Azure.VMSS.PublicKey
2 participants
@VeraBE @BernieWhite