Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to manage granular workspace permissions for teams #847

Open
SaamerS opened this issue May 13, 2024 · 6 comments
Open

Ability to manage granular workspace permissions for teams #847

SaamerS opened this issue May 13, 2024 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed terrakube-ui

Comments

@SaamerS
Copy link

SaamerS commented May 13, 2024

Feature description 💡

Instead of manage workspace permission, two new permissions are added:

  • Read workspaces
  • Manage workspaces

Each permission has the ability to select the workspaces that apply to that permission

ex.

Team 1 Admin of Terrakube: Has the ability to view/manage all workspaces
Team 2 Admin of X amount of workspaces
Team 3 Read of X amount of workspaces

This helps filter out larger organization and manage RBAC at the workspace level

Anything else?

No response

@SaamerS SaamerS added the enhancement New feature or request label May 13, 2024
@alfespa17
Copy link
Member

If you add a team to an organization and you don't select any permission, it will be like the same effect it will only have "read access"

@hfeixas
Copy link

hfeixas commented May 13, 2024

If you add a team to an organization and you don't select any permission, it will be like the same effect it will only have "read access"

Correct - I think this more like, could we extend a single organization to support several RBAC's instead of having to sprawl to another org when we want multiple "Workspace Management" Teams that will manage different subsets of workspaces.

@alfespa17
Copy link
Member

That could be an improvement, but I think it will require a lot of changes because of the way the java framework (elide) that we are using manage the access permission for that part of the code.

If you want to do some automation for the team and org configuration maybe you can use the Terrakube provider as an alternative if you need to manage a lot of orgs and teams

https://registry.terraform.io/providers/AzBuilder/terrakube/latest/docs/resources/team

@hfeixas
Copy link

hfeixas commented May 13, 2024

That could be an improvement, but I think it will require a lot of changes because of the way the java framework (elide) that we are using manage the access permission for that part of the code.

If you want to do some automation for the team and org configuration maybe you can use the Terrakube provider as an alternative if you need to manage a lot of orgs and teams

https://registry.terraform.io/providers/AzBuilder/terrakube/latest/docs/resources/team

Okay - that is a fair point. Then I would pivot to say, as an admin logging in, it should be easy for me to navigate through hundreds/thousands of orgs. Which means we should have some filter/intelligent searching in the Organization dropdown especially since orgs are slugged via UUID (As they should be) And not friendly names.

@alfespa17
Copy link
Member

alfespa17 commented May 13, 2024

Yeah that could a small change in the UI I like that idea.

It will only need to update this part of the react code I guess

https://github.com/AzBuilder/terrakube/blob/main/ui/src/domain/Home/MainMenu.jsx

@alfespa17 alfespa17 added terrakube-ui help wanted Extra attention is needed good first issue Good for newcomers labels May 13, 2024
@jderieg
Copy link
Contributor

jderieg commented Aug 15, 2024

If you add a team to an organization and you don't select any permission, it will be like the same effect it will only have "read access"

Correct - I think this more like, could we extend a single organization to support several RBAC's instead of having to sprawl to another org when we want multiple "Workspace Management" Teams that will manage different subsets of workspaces.

^ This would be a really nice feature-add!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed terrakube-ui
Projects
None yet
Development

No branches or pull requests

4 participants