Add all material color palette defined colors #9368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
The MaterialColorPalette previously only had the defined MaterialColor enum values that were used in the rectangular palette. The other colors were skipped as they would make the palette non-rectangular and unable to be displayed. However, now that the MaterialColor enum values are separate from the actual displayed palette, all colors can be included for those apps that need them.
What is the current behavior?
The MaterialColor enum only has the colors used in the rectangular palette.
What is the updated/expected behavior with this PR?
All material colors are defined.
How was the solution implemented (if it's not obvious)?
See code
Checklist
[ ] Added unit tests (if possible)?[ ] Added XML documentation to any related classes?[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentationBreaking changes
None
Obsoletions / Deprecations
None
Fixed issues
N/A