win32: Don't raise TextInput event when KeyDown was handled (Attempt #2) #7374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On win32, returning handled from `WM_KEYDOWN` doesn't automatically prevent a `WM_CHAR` message, resulting in #5849. Fix this by setting a flag after `WM_KEYDOWN` is handled which will make the following `WM_CHAR` message be ignored. This is the second attempt at fixing this after it was decided that #7351 was not the right approach. Fixes #5849
kekekeks
approved these changes
Jan 17, 2022
danwalmsley
added a commit
that referenced
this pull request
Jan 24, 2022
…-handed-2 win32: Don't raise TextInput event when KeyDown was handled (Attempt #2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
On win32, returning handled from
WM_KEYDOWNdoesn't automatically prevent aWM_CHARmessage, resulting in #5849.Fix this by setting a flag after
WM_KEYDOWNis handled which will make the followingWM_CHARmessage be ignored.This is the second attempt at fixing this after it was decided that #7351 was not the right approach.
Fixed issues
Fixes #5849