WIP: Typed bindings #5510
Closed
WIP: Typed bindings #5510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grokys
added a commit
to AvaloniaUI/Avalonia.Controls.TreeDataGrid
that referenced
this pull request
Feb 19, 2021
Ported over from AvaloniaUI/Avalonia#5510.
Due to NRT deficiencies.
Even though it was a no-op, `WeakReference.TryGetTarget` is slightly expensive and shows up in profiling.
|
Closing this; will reopen in a slightly different form soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Still a work in progress, but opening a PR for visibility.
Implements typed bindings which provide a non-boxing, no-reflection pipeline for binding values.
The
TypedBinding{TIn, TOut}class represents a strongly-typed binding as opposed toBindingwhich boxes value types. It is represented as a set of delegates:Readreads the value given a binding inputWritewrites a value given a binding inputLinksholds a collection of delegates which when passed a binding input return each object traversed byRead. For example if Read is implemented asx => x.Foo.Bar.Bazthen there would be three links:x => x.Foo,x => x.Foo.Barandx => x.Foo.Bar.Baz. These links are used to subscribe to change notifications.Basic code should mostly work but still needs integration with the XAML compiler. Currently typed bindings can only be created from lambda expressions at runtime.