Audit experimental features in ET/event-countdown-block

[WunderBart]

Master tracking issue: #44251
ET tracking issue: #46489

event-countdown-block is dependant on experimental features without a fallback for a scenario where such a feature is not supported anymore. Below is a list of usages that we need to update in this matter:

• wp-calypso/apps/editing-toolkit/editing-toolkit-plugin/event-countdown-block/blocks/src/edit.js

  Line 8 in 720b5da

  import { dateI18n, __experimentalGetSettings } from '@wordpress/date';

[WunderBart]

cc @mkaz

[mkaz]

The experimental get settings in wp-date is a relatively simple use. I'm not quite sure why it was marked experimental in the first place, or why it required a function to return a variable set in the date package.

The code is basically the following:

let settings = {  /* ... bunch of settings ... */  };
export function __experimentalGetSettings() { return settings; }

There are numerous ways to solve, and would depend on when/how the experimental change is made. Simply exporting the settings from the package and doing an import and check would work.

Related, @vcanales is reworking the date package, so another option would be to implement the new functions when updated.

[vcanales]

Related, @vcanales is reworking the date package, so another option would be to implement the new functions when updated.

This seems very reasonable. As you point out, the function itself returns the settings object and not much else.

On the other hand, when it was marked as experimental, the intention was to eventually deprecate it, replacing it with a settings endpoint. Here's the origin of the discussion around deprecating getSettings. I don't know if any work has been done around implementing the date settings API mentioned in that discussion.

[sirreal]

Closing this as of #47712 / p4TIVU-9xW-p2