-
Notifications
You must be signed in to change notification settings - Fork 2k
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit experimental features in WordPress Components Gallery #46496
Comments
@Automattic/team-calypso is this something that you could look into? |
@diegohaz I wonder if you have any insight into the best way to deal with experimental features? Would it be wiser to just not use them at all in this setting or is there a safe way to use them? I'm not familiar with how to do "safe" imports or anything like that. |
If it's just for internal usage and we're okay with things unexpectedly breaking, I think it's not a big problem. But, ideally, we shouldn't depend on experimental features. The problem is that code will eventually break:
If we use experimental features, we should set fixed versions in our package.json (which is currently not the case). For reference, this has already been a problem because Gutenberg was depending on experimental features of Reakit without fixing the dependency version: ariakit/ariakit#667 (comment). Reakit has a dedicated section about this that would also apply to |
That's helpful @diegohaz, thank you. I think it's safe for things to break in the components gallery world... however I'm wary of adding another potentially roadblock to upgrading the WordPress dependencies (as today it's already a hassle). I wonder if we should remove these afterall? This PR #46424 does depend on an experimental feature... in fact I don't believe there's any other component that could be used there. Luckily I believe we can switch it to just use a regular |
I'd recommend doing a pass through the list that @WunderBart provided and asking whether each one provides value in regards to the broader style compatibility efforts for |
I agree we can drop some of the experimental components out - some of them may never end up being stable ones, and if they end up stable, we can always include them back. It's worth keeping an eye on the WordPress components gallery every now and then, as the list of experimental components will always change with every new release. That being said, it's also worth keeping an open mind that the gallery is far from being a widely used tool at this point, but that is going to start changing as we continue adopting |
Worth keeping an eye on this one in case you've missed it: WordPress/gutenberg#25786 |
|
Closing this as of #47712 / p4TIVU-9xW-p2 |
Master tracking issue: #44251
WordPress Components Gallery is dependant on experimental features without a fallback for a scenario where such a feature is not supported anymore. Below is a list of usages that we need to update in this matter:
wp-calypso/client/devdocs/design/wordpress-components-gallery/alignment-matrix-control.tsx
Line 9 in 1790a34
wp-calypso/client/devdocs/design/wordpress-components-gallery/autocomplete.tsx
Line 9 in 1790a34
wp-calypso/client/devdocs/design/wordpress-components-gallery/box-control.tsx
Line 9 in 1790a34
wp-calypso/client/devdocs/design/wordpress-components-gallery/radio.tsx
Line 10 in 1790a34
wp-calypso/client/devdocs/design/wordpress-components-gallery/radio.tsx
Line 11 in 1790a34
wp-calypso/client/devdocs/design/wordpress-components-gallery/text.tsx
Line 9 in 1790a34
wp-calypso/client/devdocs/design/wordpress-components-gallery/toolbar.tsx
Line 28 in 1790a34
wp-calypso/client/devdocs/design/wordpress-components-gallery/tree-grid.tsx
Line 11 in 1790a34
wp-calypso/client/devdocs/design/wordpress-components-gallery/tree-grid.tsx
Line 12 in 1790a34
wp-calypso/client/devdocs/design/wordpress-components-gallery/tree-grid.tsx
Line 13 in 1790a34
The text was updated successfully, but these errors were encountered: