Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Justify text option not working on Simple Sites #36391

Closed
susanjanec opened this issue Sep 27, 2019 · 21 comments · Fixed by #36401
Closed

Editor: Justify text option not working on Simple Sites #36391

susanjanec opened this issue Sep 27, 2019 · 21 comments · Fixed by #36401
Assignees
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] Normal [Type] Bug

Comments

@susanjanec
Copy link

Steps to reproduce

  1. Starting at URL: https://susanjanewptestsite12345.blog/2019/08/26/a-sticky-post-example/
  2. Applied the Justify option to all paragraphs
  3. Published the post and viewed the post and not seeing the text is justified
  4. CSS class on all paragraphs showing as has-text-align-justify to confirm the justify option was applied.

What I expected

Text will appear as justified.

What happened instead

Text did not justify

Browser / OS version

Chrome Version 76.0.3809.132 / macOS High Sierra Version 10.13.6

Screenshot / Video

https://cld.wthms.co/s6UEA7

Context / Source

User came into chat regarding this issue - provided CSS as a workaround for now.

@mikeicode
Copy link

Another in 15020826-hc (the class is added to the text but not applied).

This appears to be related to the 6.5 release since this occurs on Simple sites but not on AT sites (which aren't at 6.5 yet).

@detlefholtz
Copy link

Got another in 15179400-hc.

All of the posts that the user's written in the last month aren't justifying correctly, so I sent them the CSS, which did the trick.

Unfortunately, their galleries are also not showing correctly. The images are aligned vertically instead of horizontally. Editing the galleries via the editor fixes them, but they have many galleries and have to do this manually.

@kwight
Copy link
Contributor

kwight commented Sep 27, 2019

@detlefholtz can you open a separate issue for the galleries please, thanks!

@kwight
Copy link
Contributor

kwight commented Sep 27, 2019

Ah, it turns out this has been broken since Gutenberg 6.3 (but we've been on 6.2 until skipping to 6.5 yesterday).

It's due to this change; I'll update our plugin to use the new class format.

@kwight
Copy link
Contributor

kwight commented Sep 27, 2019

D33289-code is ready for review; this will likely go out this coming Monday.

@darnelldibbles-zz
Copy link

A few reports in forums on this today - posting here so that we can notify them once things are back up and running:
https://en.forums.wordpress.com/topic/justify-function-not-working/
https://en.forums.wordpress.com/topic/justify-paragraphs/#post-3373241

@macmanx2
Copy link

@kwight kwight self-assigned this Sep 27, 2019
@kosiew
Copy link

kosiew commented Sep 28, 2019

another case here #2384169-zen

@liviopv
Copy link

liviopv commented Sep 28, 2019

Another report: #2383730-zen

@carinapilar
Copy link

Another report: #2384453-zen. User doesn't have the CSS option to use the workaround.

@CoachBirgit
Copy link

Another report: #2384515-zen (German upwork). User doesn't have the CSS option to use the workaround.

@tijosh
Copy link

tijosh commented Sep 28, 2019

Another report in #2384693-zen

@sourourn
Copy link

Another one here: #2382364-zen

@sophiegyo
Copy link

With regards to the report from #2383564-zen, it looks like paragraphs using drop caps don't actually get the justify class, even if the justify alignment is selected in the editor.

@sophiegyo
Copy link

Another report: #2386304-zen

@mlaetitia
Copy link

Another report: #2383722-zen
User doesn't have the CSS option to use the workaround.

@Agepeuve
Copy link

@Agepeuve
Copy link

And here: #2388190-zen

@kylemcph
Copy link

Another report here: #14892362-hc

Sent CSS workaround.

@sourourn
Copy link

Another one: #2388362-zen

@catkit
Copy link

catkit commented Sep 30, 2019

Chat: #15603626-hc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] Normal [Type] Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.