Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not compile on Windows 10 using --with_pango #901

Closed
dboleslawski opened this issue Apr 5, 2017 · 4 comments
Closed

does not compile on Windows 10 using --with_pango #901

dboleslawski opened this issue Apr 5, 2017 · 4 comments

Comments

@dboleslawski
Copy link

i think after fighting with this problem for hours I need another pair of eyes looking at this to tell me i'm not going crazy

Issue or Feature

trying to compile node-canvas with pango throws a bunch of error about not finding the file pango/pangocairo.h although it is located at C:\GTK\include\pango-1.0\pango

Steps to Reproduce

node-gyp rebuild --with_pango

...
c:\users\user\desktop\node-canvas-test\node_modules\canvas\src\Canvas.h(17): fatal error C1083: Cannot open include file: 'pango/pangocairo.h': No such file or directory (compiling source file ..\src\CanvasPattern.cc) [C:\Users\user\Desktop\node-canvas-test\node_modules\ca nvas\build\canvas.vcxproj]
... and so on

Your Environment

  • Version of node-canvas: 1.6.5
  • Environment: node.js v6.10.1 on Win 10 (installed using nvm-windows)

all help is greatly appreciated

@dboleslawski dboleslawski changed the title does not compile on Windows using --with_pango does not compile on Windows 10 using --with_pango Apr 5, 2017
@chearon
Copy link
Collaborator

chearon commented Apr 5, 2017

I think the Windows build is hard-coded not to use Pango, did you edit the binding.gyp?

@dboleslawski
Copy link
Author

yep, binding.gyp also includes conditions about pango for windows, although comments are dropped about freetype not running on win

maybe the binding.gyp is missing some lines to get the including of pango running. sadly im not too familiar with compiling on win to get this running..

@chearon
Copy link
Collaborator

chearon commented Apr 5, 2017

I've done it before but I don't remember the details, I don't think passing --with-pango does anything, though, you need to have the WITH_PANGO macro set to enable the relevant sections of code. And then you have to the .lib files for Pango and all of its dependencies (there are several) to the gyp file.

This is why I made canvas-prebuilt, which does have a windows Pango build by default

You can also try the MSYS install but I didn't put all of the Pango details in there

@zbjornson
Copy link
Collaborator

This was fixed in 2.x 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants