Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pexels Featured Images do not Display Credits on Full Site Editing (FSE) Themes #23408

Closed
macmanx2 opened this issue Mar 14, 2022 · 1 comment
Labels
[Extension] External Media Extend all block editor media tools to support external providers [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/

Comments

@macmanx2
Copy link
Contributor

Impacted plugin

Jetpack

Steps to Reproduce

  1. Add a featured image via Pexels.
  2. Save
  3. View the post.

A clear and concise description of what you expected to happen.

I expected a credit to be displayed below the featured image, like in these screenshots from non-FSE themes:

Twenty Twenty:
Screen Shot 2022-03-13 at 4 59 28 PM

Twenty Twenty One:
Screen Shot 2022-03-13 at 4 57 41 PM

What actually happened

No credit is displayed, as you can see in these screenshots from FSE themes:

Twenty Twenty Two:
Screen Shot 2022-03-13 at 4 56 10 PM

Stewart:
Screen Shot 2022-03-13 at 4 56 49 PM

Other information

Self-reported and reproduced on a simple WordPress.com site and a WordPress.org 5.9.2 site running Jetpack 10.7.

Operating System

macOS

OS Version

12.2.1

Browser

Firefox

Browser Version(s)

98

@macmanx2 macmanx2 added [Type] Bug When a feature is broken and / or not performing as intended [Extension] External Media Extend all block editor media tools to support external providers labels Mar 14, 2022
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Mar 14, 2022
@samiff
Copy link
Contributor

samiff commented May 9, 2022

@macmanx2 Hey 👋

It doesn't look like this issue is particularly related to Jetpack or the Pexels integration. The featured image metadata is persisted as expected, but the theme would be responsible for the display of the image caption.

Looks like the block themes rely on wp:post-featured-image to show the featured image, which is a decent compromise when moving from an older theme to a new block theme. This block does not have an option to render the caption (credit) however.

For reference, it seems like there is some ongoing discussion around "featured images + blocks": WordPress/gutenberg#27617

I've surfaced your concern in: WordPress/gutenberg#40946

@samiff samiff closed this as completed May 9, 2022
@samiff samiff removed the [Type] Bug When a feature is broken and / or not performing as intended label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Extension] External Media Extend all block editor media tools to support external providers [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

No branches or pull requests

2 participants