Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instant Search: use sentence case for form labels and buttons in wp-admin #20909

Closed
bluefuton opened this issue Sep 1, 2021 · 0 comments · Fixed by #20931
Closed

Instant Search: use sentence case for form labels and buttons in wp-admin #20909

bluefuton opened this issue Sep 1, 2021 · 0 comments · Fixed by #20931
Assignees
@bluefuton
Labels
[Feature] Search For all things related to Search [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Bug When a feature is broken and / or not performing as intended

Comments

@bluefuton
Copy link
Contributor

Impacted plugin

Jetpack

Steps to Reproduce

  1. On a site with Instant Search enabled, go to /wp-admin/admin.php?page=jetpack-search-customize.

A clear and concise description of what you expected to happen.

Our whole Search wp-admin section should use consistent capitalization.

Gutenberg has made a big effort to use sentence case consistently:

WordPress/gutenberg#18758

Here's the developer guide documentation on it:

https://developer.wordpress.org/block-editor/contributors/documentation/copy-guide/#five-pay-attention-to-capitalization

It recommends title case for product names and main titles, and sentence case for everything else.

What actually happened

We have a mixture of title case and sentence case in wp-admin's new Search section.

Sentence case:

Screen Shot 2021-09-01 at 17 59 45

Title case:

Screen Shot 2021-09-01 at 17 59 06

Other information

No response

Operating System

No response

OS Version

No response

Browser

Firefox

Browser Version(s)

No response
@bluefuton bluefuton added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Search For all things related to Search Instant Search labels Sep 1, 2021
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Sep 1, 2021
@bluefuton bluefuton mentioned this issue Sep 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bluefuton bluefuton

Labels
[Feature] Search For all things related to Search [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Instant Search customization: use sentence case consistently Automattic/jetpack
2 participants
@bluefuton @kraftbj