Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Carousel + CoBlocks Lightbox conflict #19496

Open
RealCarFax opened this issue Apr 9, 2021 · 1 comment
Open

Jetpack Carousel + CoBlocks Lightbox conflict #19496

RealCarFax opened this issue Apr 9, 2021 · 1 comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@RealCarFax
Copy link

Steps to reproduce the issue

Ensure that Jetpack Carousels are enabled and the CoBlocks plugin is installed and active

  1. Create a new page or open an existing page
  2. Insert Gallery block
  3. Add images to Gallery block
  4. On the right, leave lightbox feature disabled
  5. Publish the page, click on an image in the gallery.

What I expected

When Lightbox is disabled, I would expect no lighbox or carousel when you click on the image. Most users don't know the difference between Lightbox and Carousel.

What happened instead

If lightbox is disabled, the Jetpack carousel still shows - this appears to be misleading to our users
If lightbox is enabled, a carousel will first show, then when you close out of that the lightbox will show, I don't believe any user would expect that to occur.

It seems the workaround would be to disable the Jetapack carousel feature since this is a whole site setting (you can't turn it on/off for specific gallery blocks) and to toggle on/off the CoBlocks Lightbox feature on each gallery, but this is in no way apparent to our users.

Screenshots
Here's a GIF recording I took showing the issue:

https://d.pr/i/VYgTyT/ZKcOwkvn4T

Of note, the lightbox controls were introduced here: godaddy-wordpress/coblocks#1557

If this suggestion is implemented, this would likely help clear things up I think: #15946

@RealCarFax RealCarFax added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. labels Apr 9, 2021
@ClassicRKR27
Copy link

Another report here: 33423980-hc

Slack discussion here: p1641331472257800-slack-C03TY6J1A

@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

3 participants