Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiled Galleries: editing a gallery does not show existing gallery images #11855

Closed
jeherve opened this issue Jan 9, 2019 · 4 comments
Closed

Tiled Galleries: editing a gallery does not show existing gallery images #11855

jeherve opened this issue Jan 9, 2019 · 4 comments
Assignees
@simison @sirreal
Labels
[Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] High [Status] Blocked / Hold [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jeherve
Copy link
Member

jeherve commented Jan 9, 2019

Steps to reproduce

I started from a Jetpack site:

  1. I added a gallery to a new post. I uploaded 5 new images and a gallery was created.
  2. Immediately after the upload was over, I clicked on the Pencil icon at the top of the block.
  3. The Edit gallery modal came up, but I did not see the images I had just uploaded. Instead, I could only see all the other images I had already added to my site. Those images all appeared as selected like they were part of the gallery already.
  4. Clicking on Update Gallery to close the modal effectively added all those images to that brand new gallery.

image
@sirreal
Copy link
Member

sirreal commented Jan 10, 2019

We need to see whether this can be reproduced in core galleries and, if not, what they're doing differently.

@jeherve
Copy link
Member Author

jeherve commented Jan 10, 2019

We need to see whether this can be reproduced in core galleries

You're right, that's a problem with core galleries as well. Closing as duplicate of WordPress/gutenberg#9072

@jeherve jeherve closed this as completed Jan 10, 2019
@sirreal
Copy link
Member

sirreal commented Jan 10, 2019

We might keep this open. If this is a Gutenberg bug, we're shipping the same issue and we'll need the same fix. Tiled Gallery duplicates a lot of the same code as core.

@jeherve jeherve reopened this Jan 10, 2019
@scruffian scruffian transferred this issue from Automattic/wp-calypso Apr 3, 2019
@scruffian scruffian added [Pri] High [Type] Bug When a feature is broken and / or not performing as intended [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Status] Blocked / Hold labels Apr 3, 2019
@simison
Copy link
Member

simison commented Apr 4, 2019

Re-tested with latest Gutenberg and this now works. (Fixed in WordPress/gutenberg#12435)

@simison simison closed this as completed Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simison simison

@sirreal sirreal

Labels
[Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] High [Status] Blocked / Hold [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@simison @scruffian @jeherve @sirreal