Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize invalid URL stored for amp_invalid_url post type #1436

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Normalize invalid URL stored for amp_invalid_url post type #1436

merged 1 commit into from
Sep 17, 2018

Conversation

westonruter
Copy link
Member

  • Prevent query vars (e.g. utm) and HTTP/HTTPS from causing different copies of invalid URL post.
  • De-duplicate logic for obtaining amp_invalid_url post for a given URL.

@westonruter
Normalize invalid URL stored for amp_invalid_url post type
3f6af31 
* Prevent query vars (e.g. utm) and HTTP/HTTPS from causing different copies of invalid URL post.
* De-duplicate logic for obtaining amp_invalid_url post for a given URL.
@westonruter westonruter added this to the v1.0 milestone Sep 17, 2018
amedina
amedina approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ship it.

@westonruter westonruter merged commit 7bd13ab into develop Sep 17, 2018
@westonruter westonruter deleted the add/url-normalization branch September 17, 2018 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amedina amedina amedina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@westonruter @amedina