Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure redirect is only done if there are unsanitized errors #1241

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Ensure redirect is only done if there are unsanitized errors #1241

merged 1 commit into from
Jul 3, 2018

Conversation

westonruter
Copy link
Member

In testing, I was seeing something unexpected on a paired install. When accessing ?amp I was getting redirected to ?amp_validation_errors=0. It's clear why.

Follow-up on #1207

@westonruter westonruter added this to the v1.0 milestone Jul 3, 2018
@westonruter westonruter requested a review from kienstra July 3, 2018 00:44
kienstra
kienstra approved these changes Jul 3, 2018
View reviewed changes
Copy link
Contributor

@kienstra kienstra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

This looks good, and it makes sense that this only redirect to a non-AMP URL if there's a blocking error.

@westonruter westonruter merged commit cfa5386 into develop Jul 3, 2018
@westonruter westonruter deleted the fix/redirect branch July 3, 2018 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kienstra kienstra kienstra approved these changes

Assignees

@kienstra kienstra

Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@westonruter @kienstra