Ensure layout attributes are only allowed on supporting elements #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add validation of layout attribute value
|
Reviewing Now Hi @westonruter, |
kienstra
approved these changes
Apr 15, 2018
There was a problem hiding this comment.
Approved
Hi @westonruter,
Thanks, this PR looks good. It's nice how it uses $layout_enum. And the allowed layout values in class-amp-allowed-tags-generated.php correspond to the AMP spec for the 5 components I checked.
| * @since 1.0 | ||
| * @var array | ||
| */ | ||
| public static $layout_enum = array( |
There was a problem hiding this comment.
Good idea to use this $layout_enum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whitelist sanitizer is currently incorrectly allowing layout attributes (
layout,width,height, etc) on all elements. This PR ensures that the list of layout attributes are only merged into the attribute list for tag specs that actually declare they haveamp_layout. Additionally, the value of thelayoutattribute itself is validated against the tag spec'ssupported_layouts.This is a companion PR with #1064 to fix #1062.