Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transliteration to ASCII of artist, title and search queries #264

Open
bohning opened this issue Jun 23, 2024 · 6 comments
Open

Transliteration to ASCII of artist, title and search queries #264

bohning opened this issue Jun 23, 2024 · 6 comments

Comments

@bohning
Copy link

bohning commented Jun 23, 2024

For details, see: UltraStar-Deluxe/USDX#795

@Asvarox
Copy link
Owner

Asvarox commented Jun 24, 2024

Hi, thanks for raising this up, fix is on the way :)

@bohning
Copy link
Author

bohning commented Jun 24, 2024

Thanks! Sent you a mail!

Asvarox added a commit that referenced this issue Jun 24, 2024
ignore special characters in search, fixes #264
@bohning
Copy link
Author

bohning commented Jun 24, 2024

Does it take time to deploy it to allkaraoke.party? I just tested it and the issue is still there.

@Asvarox
Copy link
Owner

Asvarox commented Jun 24, 2024

Well, the deployment went through like 2 minutes before your comment so maybe there was still some cache in place 😅 Can you try now or provide what input you're entering?

@Asvarox Asvarox reopened this Jun 24, 2024
@bohning
Copy link
Author

bohning commented Jun 24, 2024

Ah okay, then I was too impatient. I was searching for "don't" (to find Queen's Don't Stop Me Now), but it didn't show up. However, searching for "don’t" (note the typographer’s apostrophe), it showed up (although it was displayed with the upright apostrophe. Now after the update, searching for "don't" brings up the song, that's fixed. However, ignoring special characters will not the solution for all uses cases, I guess. What if someone with an American keyboard layout wants to sing a German song containing Umlauts or a Polish song containing e.g. "ł" (e.g. Łaskowyj Maj - Biełyje rozy). The user can't type it, so searching for "Laskowyj Maj" or "Bielyje rozy" should find the song. And the opposite would also work with ASCII normalization - let's say someone submitted the song as "Laskowyj Maj - Bielyje rozy", but a user doesn't know, so he searches for "Łaskowyj Maj - Biełyje rozy", then the song would show up as well if artist/title and search string are ASCII-normalized.

See: https://github.com/anyascii/anyascii

@Asvarox
Copy link
Owner

Asvarox commented Jun 24, 2024

Ok, thanks for confirming :) . Diacritics are actually covered to some degree, though there's certainly room for improvement. For example, writing "bez tebe" will bring up "Океан Ельзи - Без тебе" as per the title, but the artist's Latin transliteration "Okean Elzy" doesn't work

I'll take a look at the lib you provided to see if it yields better results than what's already there. I really appreciate your feedback and help with this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants