Add a new target HolybroF4_PMU #27751
Conversation
|
Hi @peterbarker @tridge , This is for our Holybro DroneCAN Power Module. Please review and merge. |
There was a problem hiding this comment.
There should be two commits here.
One for the bootloaders directory, e.g.: bootloaders: add HolybroF4_PMU bootloader
One for the hwdef directory: hwdef: add HolyBroF4_PMU
@Hwurzburg is currently on holidays but does like to review these PRs before they're merged.
| @@ -0,0 +1,6 @@ | |||
| # Enable TYTS03 | |||
There was a problem hiding this comment.
| # Enable TYTS03 | |
| # Enable TSYS03 | |
|
|
||
| ## Loading Firmware | ||
|
|
||
| You can upgraded the *.bin firmware files using the dronecan GUI tool. *.apj files can also be upgraded using mossionplanner ground station. |
There was a problem hiding this comment.
| You can upgraded the *.bin firmware files using the dronecan GUI tool. *.apj files can also be upgraded using mossionplanner ground station. | |
| You can upgrade the *.bin firmware files using the DroneCan GUI tool. *.apj files can also be upgraded using the MissionPlanner ground station. |
|
|
||
| ## Status LED | ||
|
|
||
| - Flashing quickly continuously: MCU is in the bootloader stage, waiting for firmware to be flash |
There was a problem hiding this comment.
| - Flashing quickly continuously: MCU is in the bootloader stage, waiting for firmware to be flash | |
| - Flashing quickly continuously: MCU is in the bootloader stage, waiting for firmware to be flashed | |
|
|
||
| ## Mechanical Spec | ||
|
|
||
| - Size: 45mm��41mm��26mm (Not Include Cable) |
There was a problem hiding this comment.
| - Size: 45mm��41mm��26mm (Not Include Cable) | |
| - Size: 45mm��41mm��26mm (not including cable) | |
|
|
||
| # blue LED0 marked as ACT | ||
| PB0 LED OUTPUT HIGH | ||
| define HAL_LED_ON 0 |
There was a problem hiding this comment.
I don't think this LED will blink at the moment. You need to set things like this now:
define AP_NOTIFY_GPIO_LED_1_ENABLED 1
define AP_NOTIFY_GPIO_LED_1_PIN 90
|
|
||
| define DMA_RESERVE_SIZE 0 | ||
|
|
||
| define HAL_DISABLE_LOOP_DELAY |
There was a problem hiding this comment.
No longer used - this line is not effective
|
|
||
| define HAL_DISABLE_LOOP_DELAY | ||
|
|
||
| define HAL_NO_MONITOR_THREAD |
There was a problem hiding this comment.
This line doesn't do anything
|
I have already made all the modifications according to your suggestions. |
|
Hi @peterbarker is it good to merge now? |
|
I've created #27998 to replace this. I was unable to force-push over this branch - probably a repo setting or someone unchecked the "allow force push" option when creating the PR. The commits needed fixing to conform to our standards - check that other PR to see the shape they need to be. Please note that the many-repo pattern you're using for these developments is a little vexing to work with as the remote needs to be updated for this sort of tidy-up. I've marked my other PR as merge-on-ci-pass, so I'm going to close this one. Thanks! |
I've merged the PR I created to replace this one. |
Add a new target HolybroF4_PMU. It uses STM32F405 MCU and ALLEGRO ACS772 current sensor.