Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APM_Control: add AP_FW_Controller as common base class to roll and pitch controlers #27747

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IamPete1
Copy link
Member

@IamPete1 IamPete1 commented Aug 4, 2024

This moves to a shared base class between the plane roll and pitch controllers, there is lots of shared code which was duplicated. This helps with future tidyups as they now only need to happen in one place.

@IamPete1 IamPete1 added the Plane label Aug 4, 2024
@IamPete1
Copy link
Member Author

IamPete1 commented Aug 4, 2024

This is a example of something it would simplify. #27694

@peterbarker
Copy link
Contributor

I tried this on for size and got bounced: #22023

"Needs a lot of testing" was not the only comment made.

From the meeting notes:

UTC0016 - [APM_Control: factor out an AP_PitchRollController base class by peterbarker · Pull Request #22023 · ArduPilot/ardupilot · GitHub](https://github.com/ArduPilot/ardupilot/pull/22023/files)

    Parameter conversion
    Check scale factor
    Pitch tracking in TECS

... and it was also stated that increasing complexity in this area was not wanted and burning those extra bytes was fine.

@timtuxworth
Copy link
Contributor

This is awesome. It's a very nice structural change that should make some other things much easier in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants