Scripting: added copter deploy example #26651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess we can't use the existing arm() binding because of one of these issues?
|
this one, plus I think it is clearer to have arm_force so users don't use it by mistake |
rmackay9
approved these changes
Jun 2, 2024
|
Ping @tridge - should be an easy fix/merge |
peterbarker
reviewed
Jul 24, 2024
| @@ -96,6 +96,7 @@ class AP_Arming { | |||
| // these functions should not be used by Copter which holds the armed state in the motors library | |||
| Required arming_required() const; | |||
| virtual bool arm(AP_Arming::Method method, bool do_arming_checks=true); | |||
| virtual bool arm_force(AP_Arming::Method method) { return arm(method, false); } | |||
There was a problem hiding this comment.
It would be preferable to check the number of arguments being passed to the C function (lua_gettop?) rather than creating methods like this, IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this monitors climb with raw pressure and force arms in LAND mode on descent
this script was written to help a student project dropping a copter from a rocket, but I have wanted force arm in other places