Make Camera.setView options consistent with Camera.flyTo #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 15, 2015 11:49
Conflicts: CHANGES.md
| @@ -15,11 +15,17 @@ Change Log | |||
| * Deprecated `PerspectiveFrustum.getPixelSize`, use `PerspectiveFrustum.getPixelDimensions` instead. It will be removed in 1.17. | |||
| * Deprecated `PerspectiveOffCenterFrustum.getPixelSize`, use `PerspectiveOffCenterFrustum.getPixelDimensions` instead. It will be removed in 1.17. | |||
| * Deprecated `Scene\HeadingPitchRange`, use `Core\HeadingPitchRange` instead. It will be removed in 1.17. | |||
| * Deprecated `Camera.setView`, use `EllipsoidGeometry` or `Entity.ellipsoid` instead. It will be removed in 1.17. | |||
There was a problem hiding this comment.
Submit an issue for the deprecated calls.
|
@bagnell can you review this? |
| @@ -210,7 +212,7 @@ define([ | |||
| this._max2Dfrustum = undefined; | |||
|
|
|||
| // set default view | |||
| this.viewRectangle(Camera.DEFAULT_VIEW_RECTANGLE, scene.mapProjection.ellipsoid); | |||
| rectangleCameraPosition3D(this, Camera.DEFAULT_VIEW_RECTANGLE, this.position, true); | |||
There was a problem hiding this comment.
@bagnell using this.setView here breaks a whole bunch of the tests and I couldn't figure out why.
|
@bagnell this is ready for review now. i finished making the changes i wanted to. |
This was referenced Oct 19, 2015
Conflicts: CHANGES.md
bagnell
added a commit
that referenced
this pull request
Oct 21, 2015
Make Camera.setView options consistent with Camera.flyTo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3088
Camera.setViewto take the same arguments asCamera.flyToCamera.setViewwas changed to be looking straight down.options.duration <= 0inCamera.flyTo, camera callsCamera.setViewsetView,viewRectangleandflyToCamera.viewRectangle