Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readline shortcuts #50

Open
danobi opened this issue Dec 4, 2023 · 1 comment
Open

Readline shortcuts #50

danobi opened this issue Dec 4, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@danobi
Copy link

danobi commented Dec 4, 2023

Sweet tool! I was playing around a bit and I was really missing the standard readline shortcuts.

Is your feature request related to a problem? Please describe.

I don't really know sql that well so I was messing around with some queries. But it got annoying to need to copy paste and then left arrow / right arrow to edit the statements. I was wishing it was possible to up-arrow to get previous history.

Describe the solution you'd like

Would be nice if GQL could support standard readline shortcuts. If it were up to me (big caveat), I would use rustyline: https://github.com/kkawakam/rustyline. I've used it in the past for https://github.com/danobi/btrd and it worked quite well.

I wouldn't mind sending a PR for this if you think it's ok.

Describe alternatives you've considered
Could do custom readline implementation in the cli crate.

Additional context
N/A

@AmrDeveloper AmrDeveloper added the enhancement New feature or request label Dec 5, 2023
@AmrDeveloper
Copy link
Owner

Hello @danobi,

Line Editor is very important feature to add, i think rustyline is great but i am experimenting with new custom line editor implementation now with more features like Auto pair complete, better syntax highlighter ...etc, once the core is done i will mention you here and we can compare and check which option is better and add it.

Thank you,
Amr Hesham

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants