Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: split_by_seasons FALSE API input not working #5

Open
mattyanselmo opened this issue Sep 9, 2022 · 1 comment
Open

[Bug]: split_by_seasons FALSE API input not working #5

mattyanselmo opened this issue Sep 9, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@mattyanselmo
Copy link
Contributor

What happened?

The split_by_seasons 'false' option is not working in the API, as can be tested here.

When I try to select "false" from the dropdown menu I get a 500 error. Through the package's get_player_goals_added() function, you can pass "" or NULL or TRUE into this input to get what you expect, respectively, but not "false" or FALSE, or as it turns out, "fart" either.

Version

0.1.1

What version of Python or R are you using?

R 3.6.x

What operating system are you using?

Windows

Relevant log output

No response

@mattyanselmo mattyanselmo added the bug Something isn't working label Sep 9, 2022
@bgrnwd bgrnwd transferred this issue from American-Soccer-Analysis/itscalledsoccer Nov 7, 2022
@bgrnwd bgrnwd assigned bgrnwd and benbellman and unassigned bgrnwd Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants