Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentry: rateLimit type "uid" #132

Closed
Ivshti opened this issue Apr 19, 2019 · 0 comments · Fixed by #136
Closed

sentry: rateLimit type "uid" #132

Ivshti opened this issue Apr 19, 2019 · 0 comments · Fixed by #136
Assignees
Milestone

Comments

@Ivshti
Copy link
Member

Ivshti commented Apr 19, 2019

allow rate limiting by session uid

this will be very similar to ip, except it wouldn't allow non-authenticated users to submit at all

this is not spec'd up, but it's very easy: the same as type ip but using sid ({ type: "sid", timeframe: .. })

should be implemented here: https://github.com/AdExNetwork/adex-validator-stack-js/blob/df625fecad988319bb46f40244820c6dc45586e0/services/sentry/lib/access.js#L45 using pretty much the same code

@Ivshti Ivshti added this to the v0.5 milestone Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants