Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging statement #18647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix logging statement #18647

wants to merge 1 commit into from

Conversation

logresearch
Copy link

Description

This pull request addresses a minor improvement in the logging statement of the failJob method within the job handling logic. Specifically, it changes the word "fails" to "failed" to improve grammatical consistency.

Changes Made

  • Updated the logging statement from "Copy Job {} fails with status: {}" to "Copy Job {} failed with status: {}".

Rationale

The previous logging statement used "fails," which is present tense, while the method name failJob and the context imply a past action. The change to "failed" aligns the tense with the past action, making the log message clearer and more grammatically correct.

Code Diff

@Override
public void failJob(AlluxioRuntimeException reason) {
    setJobState(JobState.FAILED, true);
    mFailedReason = Optional.of(reason);
    JOB_COPY_FAIL.inc();
-    LOG.info("Copy Job {} fails with status: {}", mJobId, this);
+    LOG.info("Copy Job {} failed with status: {}", mJobId, this);
}

@alluxio-bot
Copy link
Contributor

Thank you for your pull request.
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement (CLA).
It's all electronic and will take just a few minutes. Please download CLA form here, sign, and e-mail back to cla@alluxio.org

@logresearch
Copy link
Author

logresearch commented Jul 3, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants