-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alluxio DoraMetaManger bug: update the listCache when load from ufs #18535
base: main
Are you sure you want to change the base?
Fix alluxio DoraMetaManger bug: update the listCache when load from ufs #18535
Conversation
Thank you for your pull request. |
alluxio-bot, check this please |
Automated checks report:
Some checks failed. Please fix the reported issues and reply |
alluxio-bot, check this please |
Automated checks report:
Some checks failed. Please fix the reported issues and reply |
alluxio-bot, check this please |
Automated checks report:
Some checks failed. Please fix the reported issues and reply |
alluxio-bot, check this please |
Automated checks report:
Some checks failed. Please fix the reported issues and reply |
Automated checks report:
All checks passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! I have an additional question: how do you find the inconsistent issue? By using alluxio In a real production environment or just by reading the code?
*/ | ||
public Optional<FileStatus> getFromUfs(String path) throws IOException { | ||
public Optional<UfsStatus> getFromUfs(String path, UnderFileSystem ufs) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually alluxio is able to get ufs from an instance. I don't really understand why add ufs into paramter list.
if (ufsStatus.isPresent() && ufsStatus.get().isFile()) { | ||
if (mXAttrWriteToUFSEnabled) { | ||
xattrMap = ufs.getAttributes(path); | ||
} | ||
fileStatus = PagedDoraWorker.buildFileStatusFromUfsStatus( | ||
mCacheManager.getUsage(), ufs.getUnderFSType(), ufsStatus.get(), path, xattrMap); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why move the logic from getFromUfs
to loadFromUfs
?
btw, please first sign the CLA first #18535 (comment) before we approve your PR, thanks! |
What changes are proposed in this pull request?
When load fileStatus from UFS,not only updates the metaStore, but also updates the listCache.
Why are the changes needed?
There is an inconsistency problem with file metadata when operating "ls"
Does this PR introduce any user facing changes?
no