Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion about yaw and pitch. #32

Open
shaform opened this issue Mar 30, 2024 · 3 comments
Open

Confusion about yaw and pitch. #32

shaform opened this issue Mar 30, 2024 · 3 comments

Comments

@shaform
Copy link

shaform commented Mar 30, 2024

In your model, the forward function returns pre_yaw_gaze and pre_pitch_gaze:

return pre_yaw_gaze, pre_pitch_gaze

However, in the pipeline, the two variables are assigned as gaze_pitch and gaze_yaw:

gaze_pitch, gaze_yaw = self.model(img)

It seems yaw and pitch are reversed. Why would this be the case?

@tiamo405
Copy link

Have you found the reason why? If left as is, can it be trained?

@tiamo405
Copy link

line 207 train.py: pitch, yaw = model(images_gaze)
line 22,23:
self.fc_yaw_gaze = nn.Linear(512 * block.expansion, num_bins)
self.fc_pitch_gaze = nn.Linear(512 * block.expansion, num_bins)
line 68 69 70:
pre_yaw_gaze = self.fc_yaw_gaze(x)
pre_pitch_gaze = self.fc_pitch_gaze(x)
return pre_yaw_gaze, pre_pitch_gaze
Because both have the same calculation structure, I think changing the return part is fine, the result when training will not affect anything.

@shaform
Copy link
Author

shaform commented Aug 22, 2024

It turns out the pipeline was not written by the authors, but it was created in #18. So perhaps the PR author would know the answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants