Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining 'esm' module loader dependencies #4788

Open
turadg opened this issue Mar 9, 2022 · 2 comments · Fixed by #4789
Open

Remove remaining 'esm' module loader dependencies #4788

turadg opened this issue Mar 9, 2022 · 2 comments · Fixed by #4789
Labels
tooling repo-wide infrastructure

Comments

@turadg
Copy link
Member

turadg commented Mar 9, 2022 •
edited
Loading

What is the Problem Being Solved?

Tech debt and might block #4727. (A smaller change unblocked #4722)

It's not maintained and it has resulted in time lost debugging things like optional chaining support in its transformation.

Description of the Design

Use Node.js ESM (NESM). Process: remove 'esm' from the project and burn down errors.

Security Considerations

--

Test Plan

CI
@turadg turadg added the tooling repo-wide infrastructure label Mar 9, 2022
@turadg turadg linked a pull request Mar 9, 2022 that will close this issue
build: 'module' type for root package #4789
Merged
@turadg turadg mentioned this issue Mar 10, 2022
Merged
@mergify mergify bot closed this as completed in #4789 Mar 10, 2022
@turadg turadg reopened this Mar 10, 2022
@dckc
Copy link
Member

dckc commented Mar 14, 2022

I thought we already had a bug for this... ah: #527 . How is this different?

@turadg
Copy link
Member Author

turadg commented Mar 14, 2022

How is this different?

This is to clear out the handful of remaining uses of "esm" module loader and all the references to it.

@dckc dckc changed the title Remove 'esm' module loader Remove remaining 'esm' module loader dependencies Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tooling repo-wide infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: 'module' type for root package Agoric/agoric-sdk
3 participants
@turadg @dckc @Tartuffo