fix(wallet): handle cancelled offer state #4292
Conversation
|
I wonder if it makes sense to show what assets were actually transferred vs returned inside the "completed" offer. I noticed that even if you were outbid on a card the offer shows "completed" but you didn't actually lose your give/get your want. |
samsiegart
force-pushed
the
wallet-exit
branch
from
f28bc65
to
d152b49
Compare
This is a good idea, maybe a "refunded" state. Zoe currently doesn't do anything to distinguish this result, so it would take some work on the Zoe service to be able to report it. We could instead hack together something in the wallet backend to heuristically determine that it was a refund (not my preference). @erights, thoughts? |
| const isOfferCompleted = | ||
| status === 'accept' || | ||
| status === 'decline' || | ||
| status === 'complete' || | ||
| status === 'rejected' || | ||
| status === 'cancel'; | ||
|
|
There was a problem hiding this comment.
| const isOfferCompleted = | |
| status === 'accept' || | |
| status === 'decline' || | |
| status === 'complete' || | |
| status === 'rejected' || | |
| status === 'cancel'; | |
| const isOfferCompleted = ['accept', 'decline', 'complete', 'rejected', 'cancel'].includes(status); |
There was a problem hiding this comment.
@samsiegart @michaelfig
Where does this status string come from? Where are its possible values defined?
There was a problem hiding this comment.
I'm not sure if we have any good documentation on that. The implementation is in https://github.com/Agoric/agoric-sdk/blob/master/packages/wallet/api/src/lib-wallet.js (search for "status:")
|
Will merge to fix #4243, we can continue the discussion here or open an issue if need be |
Fixes: #4243
Screenshot: