Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing Far declarations on some iterables #4250

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Fix missing Far declarations on some iterables #4250

merged 1 commit into from
Jan 10, 2022

Conversation

erights
Copy link
Member

@erights erights commented Jan 7, 2022

No description provided.

@erights erights requested a review from dckc January 7, 2022 06:50
@erights erights self-assigned this Jan 7, 2022
dckc
dckc reviewed Jan 7, 2022
View reviewed changes
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a test. Is there a reason to skip a regression test for this fix?

Meanwhile, I hope to see if it fixes a problem I was seeing...

@erights erights force-pushed the markm-missing-far-iterables branch from 7692d0b to 9af71ab Compare January 9, 2022 05:46
@erights
Copy link
Member Author

erights commented Jan 9, 2022

Hi @dckc tests added. PTAL. Thanks.

@erights erights requested a review from dckc January 9, 2022 07:23
@erights erights force-pushed the markm-missing-far-iterables branch from 236fc8d to c4024cb Compare January 9, 2022 23:52
@erights erights force-pushed the markm-missing-far-iterables branch 2 times, most recently from 231ae2a to 063614b Compare January 10, 2022 03:50
dckc
dckc approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@erights erights added the automerge:squash Automatically squash merge label Jan 10, 2022
@mergify mergify bot merged commit fe997f2 into master Jan 10, 2022
@mergify mergify bot deleted the markm-missing-far-iterables branch January 10, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dckc dckc dckc approved these changes

@michaelfig michaelfig Awaiting requested review from michaelfig

Assignees

@erights erights

Labels
automerge:squash Automatically squash merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erights @dckc