feat(wallet): Fix icons and list rendering bugs #3827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
Sep 15, 2021
Comment on lines
17
to
19
| 'type': 'payment', | ||
| 'data': i | ||
| 'data': i, | ||
| 'id': i.id, |
There was a problem hiding this comment.
Just a minor stylistic thing: for properties that are valid identifiers, please remove the single-quotes.
i.e.
type: 'payment',
data: i,
id: i.id,
There was a problem hiding this comment.
No problem, done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3793
There was a bug that also affected the old implementation where changing a dapp petname would move it in the list (they're sorted alphabetically), but the text inputs would get swapped for the dapps that changed places. It was really obvious in the requests view because if multiple dapps showed up at once they'd all end up with the same petname. The fix was to properly index the list like:
#each items as item, i->#each items as item, i (id(item)). This also reduces some layout thrashing/flickering as requests are shown/hidden.