fix: Remove remaining uses of -r esm #3710
Conversation
kriskowal
force-pushed
the
kris-resm-vestiges
branch
from
10e356d
to
e5bf91e
Compare
| spawn: childProcessPowers.spawn, | ||
| osType: osPowers.type, | ||
| readdirSync: fsPowers.readdirSync, | ||
| readFileSync: fsPowers.readFileSync, |
There was a problem hiding this comment.
Although I found an if __name__ == '__main__' idiom for NESM, but even then, I struggled to preserve your intent of limiting the scope of powers to the entrypoint, forcing a certain discipline to thread them through. One of the troubles was having to find names that would not run afoul of eslint name shadowing prohibitions. I arrived at this convention, with *Powers module names, which is mildly dissatisfying but got the job done surgically. It might be worthwhile to factor out a replay-entrypoint.js that imports this module and the powers instead.
There was a problem hiding this comment.
GMTA... I did the same thing recently... Modulo Powers vs Top
| spawn: childProcessPowers.spawn, | ||
| osType: osPowers.type, | ||
| readdirSync: fsPowers.readdirSync, | ||
| readFileSync: fsPowers.readFileSync, |
There was a problem hiding this comment.
GMTA... I did the same thing recently... Modulo Powers vs Top
kriskowal
force-pushed
the
kris-resm-vestiges
branch
from
e5bf91e
to
b9f16ba
Compare
This change follows #527 to erase some remaining evidence of -r esm in shebangs and incidentally also follows #3708 removing the env -S flag that does not work on Linux for these cases.