fix: Treasury burn debt repayment before zeroing the amount owed #3604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
added
bug
fixes #3495 fixed getCollateralBrand in the innerFacet, which wasn't a method. Moved a check for empty denominators to be after an await. Added assertVaultHoldsNoRun() in close. Added a test for closing a loan.
Chris-Hibbert
force-pushed
the
treasuryRepairs-3495
branch
from
908e090
to
df45399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3495
fixed getCollateralBrand in the innerFacet, which wasn't a method.
Moved a check for empty denominators to be after an await.
Added assertVaultHoldsNoRun() in close.
Added a test for closing a loan.