Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore an xsnap build output #2887

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Ignore an xsnap build output #2887

merged 1 commit into from
Apr 16, 2021

Conversation

erights
Copy link
Member

@erights erights commented Apr 15, 2021

After doing the normal installing building and testing, a git status was bugging me about an untracked fixture-snap-pool. It seemed harmless, so I am optimistically adding it to the closest .gitignore. With that, git status is clean again.

@erights erights requested review from warner and dckc April 15, 2021 06:00
@erights erights self-assigned this Apr 15, 2021
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this should be ignored. It's generated during snapshot testing (from 865ba54 )

But before I approve... is there some other filename convention I should have used, @warner ?

@warner
Copy link
Member

warner commented Apr 16, 2021

Ideally it'd be a proper tempfile (mktmp or whatever), deleted when the test is complete. Failing that, it'd be nice to make it obviously not code, so maybe make a directory named _test_output/ and put it in there or something. But if that's too much of a hassle, I'm ok with just .gitignoreing the file as-is.

Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2897 represents @warner 's suggestion to use temp files.

meanwhile, this is ok.

@erights erights merged commit 646b621 into master Apr 16, 2021
@erights erights deleted the ignore-fixture-snap-pool branch April 16, 2021 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants