🐛 Fix removeEmpty for primitive types

src/main.ts

@@ -0,0 +1,36 @@
+import loggerFactory from './index';
+
+const logger = loggerFactory({
+    enableFields: ['req.hello', 'req.password'],
+    config: {
+        redact: ['*.*.password'],
+    },
+});
+
+const tmp = {
+    body: 'aces high',
+    password: 'sensitive',
+    somethingTmp: {
+        password: 'tajne',
+    },
+};
+
+logger.info({ tmp: tmp, something: 666 });
+
+logger.info({ req: { body: 42, method: 'POST' } });
+logger.info({ req: { body: 0, method: 'POST' } });
+logger.info({ req: { body: Symbol(), method: 'POST' } });
+logger.info({ req: { body: 42.69, method: 'POST' } });
+logger.info({ req: { body: false, method: 'POST' } });
+logger.info({ req: { body: '', method: 'POST' } });
+logger.info({ req: { body: null, method: 'POST' } });
+logger.info({ req: { body: undefined, method: 'POST' } });
+logger.info({ req: { body: {}, method: 'POST' } });
+logger.info({ req: { body: { a: 'a' }, method: 'POST' } });
+logger.info({ req: { body: [], method: 'POST' } });
+logger.info({ req: { body: [1], method: 'POST' } });
+
+import isEmptyObject = require('lodash.isempty');
+
+console.log(isEmptyObject('A'));
+console.log(isEmptyObject(''));

src/tests/serializers.test.ts

@@ -425,3 +425,57 @@ test('req body string serialization', () => {
 
     logger.info({ req });
 });
+
+const nonEmptyValues = [42, 0, 42.69, false, 'hello', { a: 'b' }, [1]];
+test.each(nonEmptyValues)('req body serialization - nonempty values: %s', (value) => {
+    const loggerWrites = jest.fn();
+    const req = {
+        method: 'GET',
+        url: 'www.example.com',
+        body: value,
+    };
+
+    const logger = loggerFactory({
+        streams: [
+            {
+                stream: new Writable({
+                    write: (chunk, _encoding, next) => {
+                        const json = JSON.parse(chunk);
+                        expect(json.req.body).toEqual(value);
+                        loggerWrites();
+                        next();
+                    },
+                }),
+            },
+        ],
+    });
+
+    logger.info({ req });
+});
+
+const emptyValues = [null, undefined, {}, [], ''];
+test.each(emptyValues)('req body serialization - empty values: %s', (value) => {
+    const loggerWrites = jest.fn();
+    const req = {
+        method: 'GET',
+        url: 'www.example.com',
+        body: value,
+    };
+
+    const logger = loggerFactory({
+        streams: [
+            {
+                stream: new Writable({
+                    write: (chunk, _encoding, next) => {
+                        const json = JSON.parse(chunk);
+                        expect(json.req.body).toBe(undefined);
+                        loggerWrites();
+                        next();
+                    },
+                }),
+            },
+        ],
+    });
+
+    logger.info({ req });
+});

src/utils.ts

@@ -1,8 +1,17 @@
 import { Request } from 'express';
 import { Dictionary } from 'lodash';
-import isEmpty = require('lodash.isempty');
+import isEmptyObject = require('lodash.isempty');
 import omit = require('omit-deep');
 
+const isPrimitive = (val: any) => val !== Object(val);
+
+const isEmpty = (val: any) => {
+    if (isPrimitive(val)) {
+        return val === null || val === undefined || val === '';
+    }
+    return isEmptyObject(val);
+};
+
 const removeEmpty = (obj: Dictionary<any>): object =>
     omit(
         obj,