Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer links - "become a contributor" and "support us" are not opening in new tab/new window #341

Closed
SatyamSetia opened this issue Jul 8, 2023 · 4 comments · Fixed by #342
Assignees

Comments

@SatyamSetia
Copy link
Member

Describe the bug
Specifically 2 links in the footer - "Become a contributor" and "Support us" have open in new tab icon beside the text and aria-label="open in new window" as well but clicking these links opens the target url in same tab.

To Reproduce
Observe the links in app footer.
OR
Try using a screen reader, it announces these link as "open in new window" but it gets open in same tab.

Expected behaviour
"Become a contributor" and "Support us" should open in new tab.

Screenshots

Screenshot 2023-07-08 at 12 47 31 PM
@SatyamSetia
Copy link
Member Author

Hey, @EmmaDawsonDev
Just wanted to share my interest on working this bug fix if in-case you find it to be a relevant issue to be fixed.

My proposal for the fix -
Using "target" attribute on these 2 anchor tags

@EmmaDawsonDev
Copy link
Member

Hi Satyam, well spotted! These links are actually not meant to open in a new window, I must've missed asking the previous contributor to remove the icons. Please feel free to remove the icons.

@SatyamSetia
Copy link
Member Author

Acknowledged 👍

@SatyamSetia
Copy link
Member Author

Hey, @EmmaDawsonDev
I have raised a PR for fixing this issue. Please find the changes here - #342
Requesting your review whenever you get time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants