-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing arrow keys navigation support in theme switcher menu #340
Comments
Hello @SatyamSetia, thanks for raising an issue in this project. The maintainers of this project are volunteers so please be understanding if it takes time before you get a response. We still appreciate your help with raising issues! |
Hey, @EmmaDawsonDev My proposal for the fix - |
Hi Satyam, Thanks for raising this issue. This component follows the disclosure pattern from the APG. This is usually recommended over the menu pattern and preferred by screen reader users. The menu pattern is misunderstood and the word misused. It's meant specifically for things that behave like native operating system menus, not for drop downs, pop ups or anything else on a website we might refer to as a menu. This article is a good read https://adrianroselli.com/2023/05/be-careful-using-menu.html |
Thanks for the details @EmmaDawsonDev. It makes sense to me as well now. Looks like we can close this issue since it is a valid implementation. |
Describe the bug
Keyboard navigation using arrow keys is not supported in theme-switcher menu items currently.
To Reproduce
Try using arrow keys on theme-switcher. It scrolls the page instead of navigating among theme menu items.
Expected behaviour
Since it is a menu with 3 menu items - Device settings, light mode and dark mode. As per ideal accessibility experience -
Additional context
Reference link with more details on ideal menu button experience from a11y standpoint - https://www.w3.org/WAI/ARIA/apg/patterns/menubar/
The text was updated successfully, but these errors were encountered: