-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version in RB-3.2 branch #1524
Comments
See the comment here ~ originally I had intended OpenEXRConfig.h to include openexr_version.h, but ran into a snarl: #1386 (comment) Things have been further sorted out subsequently, should be possible to get it right now. |
Just for the records openexr/src/wrappers/python/setup.py also depends on the contents of
|
A good supporting argument for |
If still needed, see e.g. libtiff again for CMake ideas that gives pretty much equivalent to the python above: https://gitlab.com/libtiff/libtiff/-/blob/69eef88fc0e446c35213471f7277ee86265e5871/CMakeLists.txt#L35-L46 and https://gitlab.com/libtiff/libtiff/-/blob/69eef88fc0e446c35213471f7277ee86265e5871/cmake/AutotoolsVersion.cmake |
ah, I see it, thanks, we could emulate this.
|
This should be resolve by #1527. |
The release version appears to be specified in two places, in
OpenEXRConfig.h.in
and inopenexr_version.h
, so as it stands, the version is correct in the current 3.2 release branch but for subsequent patch releases would need to updated in two locations, which is problematic. This needs to get sorted out prior to release.Presumably,
OpenEXRConfig.h.in
should read the values fromopenexr_version.h
(or theCMakeLists.txt
should).The text was updated successfully, but these errors were encountered: